Remove ´profiles/suites.nix` and fix hardware module in hosts documentation #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacman99
reviewed
May 18, 2021
| modules = [ hardware.purism-librem-13v3 ]; | ||
| modules = [ nixos-hardware.nixosModules.purism-librem-13v3 ]; |
There was a problem hiding this comment.
Based on your other comment from the thread, could you also apply this patch:
diff --git a/doc/concepts/hosts.md b/doc/concepts/hosts.md
index 1fa9028..d9902eb 100644
--- a/doc/concepts/hosts.md
+++ b/doc/concepts/hosts.md
@@ -33,15 +33,15 @@ that you intend to use on your machine.
flake.nix:
```nix
{
- nixos.hosts = mkMerge [
- (devos.lib.importHosts ./hosts)
- {
+ nixos = {
+ imports = [ (devos.lib.importHosts ./hosts) ];
+ hosts = {
librem = {
channelName = "latest";
modules = [ hardware.purism-librem-13v3 ];
};
- }
- ];
+ };
+ };
}There was a problem hiding this comment.
Just to update the doc to match flake.nix
blaggacao
approved these changes
May 18, 2021
|
@Pacman99 Let's make that other change separate, as this change is a valid bugfix on its own. So including ASAP is of value on its own. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #282
As I understand it, this file isn't needed anymore and the hardware module is not defined properly in the documentation.